lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [V9fs-developer] [PATCH 2/2] fs/9p: detecting invalid options as much as possible
From
Date
Hi Dominique,

Thanks for your quick reply and comment.


在 2018年4月16日,下午3:56,Dominique Martinet <asmadeus@codewreck.org> 写道:
>
> Chengguang Xu wrote on Mon, Apr 16, 2018:
>> default:
>> + p9_debug(P9_DEBUG_ERROR,
>> + "unrecognized mount option \"%s\" or missing value\n",
>> + p);
>> continue;
>
> The problem with that is that the same options are passed to the vfs,
> net and transport init later on - none of which know the full subset of
> valid options to tell what option has been recognized or not.
>
> Unless we do some backward-incompatible breakage of passing all the
> net/transport options in its own option (e.g. net=foo:bar:moo) there
> unfortunately is no nice way of fixing this now.

Yes, I agree with you.


>
>
> (I don't mind the rest of the patches, although I'd say if we hit ENOMEM
> there is likely trouble going on so I'm not so sure about hiding it if
> there also is an EINVAL, but I don't really care)

The initial motivation of hiding ENOMEM here is when reproducing the error,
the error code may change by system condition(more accurately memory condition),
after this patch the error code will be persistent. However, as you pointed out,
when we hit ENOMEM there would be a serious trouble, so in real life maybe we
cannot benefit from it. What do you think?

Thanks,
Chengguang.

\
 
 \ /
  Last update: 2018-04-16 13:38    [W:0.027 / U:0.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site