lkml.org 
[lkml]   [2018]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag
On Fri, Apr 13, 2018 at 12:19:27PM +0100, Mark Brown wrote:
> On Thu, Apr 12, 2018 at 11:14:35PM +0200, Peter Rosin wrote:
>
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * Driver for the MAX9860 Mono Audio Voice Codec
> > *
>
> Please don't mix C and C++ comments like this - it looks unintentional
> and messy. Just convert the entire comment block to C++ so it's
> consistent with itself.

NAK - that is exactky the wrong way to go. Normal Linux comments are
classi C-style comments and should remain so. SPDX tags use c++
comments exactly to be different and stick out.



---end quoted text---

\
 
 \ /
  Last update: 2018-04-15 09:33    [W:0.050 / U:6.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site