Messages in this thread | | | Date | Thu, 12 Apr 2018 16:16:30 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/4] lan78xx: Read initial EEE setting from Device Tree |
| |
On Thu, Apr 12, 2018 at 02:55:34PM +0100, Phil Elwell wrote: > Add two new Device Tree properties: > * microchip,eee-enabled - a boolean to enable EEE > * microchip,tx-lpi-timer - time in microseconds to wait after TX goes > idle before entering the low power state > (default 600)
Hi Phil
This looks wrong.
What should happen is that the MAC driver calls phy_init_eee() to find out if the PHY supports EEE. There should be no need to look in device tree.
Andrew
| |