lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 004/310] rtc: snvs: fix an incorrect check of return value
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>


    [ Upstream commit 758929005f06f954b7e1c87a1c9fdb44157b228f ]

    Function devm_regmap_init_mmio() returns an ERR_PTR on error. However,
    in function snvs_rtc_probe() its return value is checked against NULL.
    This patch fixes it by checking the return value with IS_ERR().

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/rtc/rtc-snvs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/rtc/rtc-snvs.c
    +++ b/drivers/rtc/rtc-snvs.c
    @@ -257,7 +257,7 @@ static int snvs_rtc_probe(struct platfor
    of_property_read_u32(pdev->dev.of_node, "offset", &data->offset);
    }

    - if (!data->regmap) {
    + if (IS_ERR(data->regmap)) {
    dev_err(&pdev->dev, "Can't find snvs syscon\n");
    return -ENODEV;
    }

    \
     
     \ /
      Last update: 2018-04-11 22:14    [W:3.382 / U:1.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site