lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 173/310] clk: Fix __set_clk_rates error print-string
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bryan O'Donoghue <pure.logic@nexus-software.ie>


    [ Upstream commit ee177c5d6369f8e5d3e4793dce501cf4431313a1 ]

    When failing to set a clock the printout emitted is incorrect.
    "u32 rate" is formatted as %d and should be %u whereas "unsigned long
    clk_set_rate()" is formatted as %ld and should be %lu as per
    Documentation/printk-formats.txt.

    Fixes: 2885c3b2a3da ("clk: Show correct information when fail to set clock rate")
    Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/clk/clk-conf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/clk/clk-conf.c
    +++ b/drivers/clk/clk-conf.c
    @@ -106,7 +106,7 @@ static int __set_clk_rates(struct device

    rc = clk_set_rate(clk, rate);
    if (rc < 0)
    - pr_err("clk: couldn't set %s clk rate to %d (%d), current rate: %ld\n",
    + pr_err("clk: couldn't set %s clk rate to %u (%d), current rate: %lu\n",
    __clk_get_name(clk), rate, rc,
    clk_get_rate(clk));
    clk_put(clk);

    \
     
     \ /
      Last update: 2018-04-11 21:03    [W:4.127 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site