lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] isofs compress: Remove VLA usage
On Tue, Apr 10, 2018 at 11:15:28PM -0700, Joe Perches wrote:
> On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote:
> > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote:
> > > > As part of the effort to remove VLAs from the kernel[1], this changes
> > > > the allocation of the bhs and pages arrays from being on the stack to being
> > > > kcalloc()ed. This also allows for the removal of the explicit zeroing
> > > > of bhs.
> > > >
> > > > https://lkml.org/lkml/2018/3/7/621
> > >
> > > Do you even bother reading the feedback given to such patches? I'm just
> > > curious,
> >
> > He made a tool mistake (sent v2 again) -- please see v4.
>
> No worries but Kyle didn't just mistakenly resend v2.
> It was a v3 with a different below the dashes changelog.
>
> Kyle, it would be good if next time you were to add a
> listing of changes in each revision below the dashes.

Shit happens...

Al, fully expecting to discover having made something spectacularly bonehead
2 minutes after sending a patch out - happens often enough.

\
 
 \ /
  Last update: 2018-04-11 08:40    [W:0.108 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site