lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] mm: remove odd HAVE_PTE_SPECIAL
From
Date


Le 11/04/2018 à 10:41, Laurent Dufour a écrit :
> On 11/04/2018 10:33, Michal Hocko wrote:
>> On Wed 11-04-18 10:03:36, Laurent Dufour wrote:
>>> @@ -881,7 +876,8 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>>>
>>> if (is_zero_pfn(pfn))
>>> return NULL;
>>> -check_pfn:
>>> +
>>> +check_pfn: __maybe_unused
>>> if (unlikely(pfn > highest_memmap_pfn)) {
>>> print_bad_pte(vma, addr, pte, NULL);
>>> return NULL;
>>> @@ -891,7 +887,7 @@ struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>>> * NOTE! We still have PageReserved() pages in the page tables.
>>> * eg. VDSO mappings can cause them to exist.
>>> */
>>> -out:
>>> +out: __maybe_unused
>>> return pfn_to_page(pfn);
>>
>> Why do we need this ugliness all of the sudden?
> Indeed the compiler doesn't complaint but in theory it should since these
> labels are not used depending on CONFIG_ARCH_HAS_PTE_SPECIAL.

Why should it complain ?

Regards
Christophe

>

\
 
 \ /
  Last update: 2018-04-11 11:00    [W:0.064 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site