lkml.org 
[lkml]   [2018]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:efi/core] efi: Reorder pr_notice() with add_device_randomness() call
    Commit-ID:  5b4e4c3aa220d07d166d3f21f158bc9c69e3c044
    Gitweb: https://git.kernel.org/tip/5b4e4c3aa220d07d166d3f21f158bc9c69e3c044
    Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    AuthorDate: Thu, 8 Mar 2018 08:00:18 +0000
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Fri, 9 Mar 2018 08:58:23 +0100

    efi: Reorder pr_notice() with add_device_randomness() call

    Currently, when we receive a random seed from the EFI stub, we call
    add_device_randomness() to incorporate it into the entropy pool, and
    issue a pr_notice() saying we are about to do that, e.g.,

    [ 0.000000] efi: RNG=0x87ff92cf18
    [ 0.000000] random: fast init done
    [ 0.000000] efi: seeding entropy pool

    Let's reorder those calls to make the output look less confusing:

    [ 0.000000] efi: seeding entropy pool
    [ 0.000000] efi: RNG=0x87ff92cf18
    [ 0.000000] random: fast init done

    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Link: http://lkml.kernel.org/r/20180308080020.22828-11-ard.biesheuvel@linaro.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    drivers/firmware/efi/efi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
    index cd42f66a7c85..92b9e79e5da9 100644
    --- a/drivers/firmware/efi/efi.c
    +++ b/drivers/firmware/efi/efi.c
    @@ -542,9 +542,9 @@ int __init efi_config_parse_tables(void *config_tables, int count, int sz,
    seed = early_memremap(efi.rng_seed,
    sizeof(*seed) + size);
    if (seed != NULL) {
    + pr_notice("seeding entropy pool\n");
    add_device_randomness(seed->bits, seed->size);
    early_memunmap(seed, sizeof(*seed) + size);
    - pr_notice("seeding entropy pool\n");
    } else {
    pr_err("Could not map UEFI random seed!\n");
    }
    \
     
     \ /
      Last update: 2018-03-09 10:15    [W:4.188 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site