lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 09/22] arm64: capabilities: Split the processing of errata work arounds
From
Date
On 09/02/18 18:18, Dave Martin wrote:
> On Fri, Feb 09, 2018 at 05:54:48PM +0000, Suzuki K Poulose wrote:
>> Right now we run through the errata workarounds check on all boot
>> active CPUs, with SCOPE_ALL. This doesn't help with detecting the
>> errata's with a SYSTEM_SCOPE. While nobody uses it, let us clean
>> this up in preparation for merging capability handling.
>
> errata; and SCOPE_SYSTEM (if I'm being pedantic)
>
> To make it clearer this this is adding support for new behaviour rather
> than changing old behaviour, perhaps change "This doesn't help ...
> While nobody uses it ..." to something like:
>
> "This wouldn't help for detecting erratum workarounds with SCOPE_SYSTEM.
> There are none yet, but we plan to introduce some: let us clean this up
> so that such workarounds can be detected and enabled correctly."

Fixed

>>
>> So, we run the checks with SCOPE_LOCAL_CPU on all CPUs and SCOPE_SYSTEM
>> checks are run only once after all the boot time CPUs are active.
>>
>> Cc: Dave Martin <dave.martin@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Otherwise,
>
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>

Thanks
Suzuki

\
 
 \ /
  Last update: 2018-03-08 13:25    [W:0.076 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site