lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 11/78] IB/ipoib: Warn when one port fails to initialize
    Date
    From: Yuval Shaia <yuval.shaia@oracle.com>

    [ Upstream commit ac6dbf7fa4707c75a247b540cc0b5c881f3d0ba8 ]

    If one port fails to initialize an error message should indicate the
    reason and driver should continue serving the working port(s) and other
    HCA(s).

    Fixes: e4b2d06892c7 ("IB/ipoib: Remove device when one port fails to init").
    Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    index 8880351df179..c35c28015f8e 100644
    --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
    +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    @@ -2207,8 +2207,10 @@ static struct net_device *ipoib_add_port(const char *format,
    int result = -ENOMEM;

    priv = ipoib_intf_alloc(hca, port, format);
    - if (!priv)
    + if (!priv) {
    + pr_warn("%s, %d: ipoib_intf_alloc failed\n", hca->name, port);
    goto alloc_mem_failed;
    + }

    SET_NETDEV_DEV(priv->dev, hca->dev.parent);
    priv->dev->dev_id = port - 1;
    @@ -2337,8 +2339,7 @@ static void ipoib_add_one(struct ib_device *device)
    }

    if (!count) {
    - pr_err("Failed to init port, removing it\n");
    - ipoib_remove_one(device, dev_list);
    + kfree(dev_list);
    return;
    }

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 08:11    [W:3.012 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site