lkml.org 
[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.4 041/101] ASoC: Intel: Skylake: Uninitialized variable in probe_codec()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e6a33532affd14c12688c0e9b2e773e8b2550f3b ]

    My static checker complains that if snd_hdac_bus_get_response() returns
    -EIO then "res" is uninitialized. Fix this by initializing it to -1 so
    that the error is handled correctly.

    Fixes: d8c2dab8381d ("ASoC: Intel: Add Skylake HDA audio driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    sound/soc/intel/skylake/skl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
    index b4844f78266f..f6c3be192cc9 100644
    --- a/sound/soc/intel/skylake/skl.c
    +++ b/sound/soc/intel/skylake/skl.c
    @@ -280,7 +280,7 @@ static int probe_codec(struct hdac_ext_bus *ebus, int addr)
    struct hdac_bus *bus = ebus_to_hbus(ebus);
    unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) |
    (AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID;
    - unsigned int res;
    + unsigned int res = -1;

    mutex_lock(&bus->cmd_mutex);
    snd_hdac_bus_send_cmd(bus, cmd);
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 06:37    [W:3.853 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site