Messages in this thread | | | From | "Prakhya, Sai Praneeth" <> | Subject | RE: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services() | Date | Thu, 8 Mar 2018 18:09:56 +0000 |
| |
/* > >> > + * Since we process only one efi_runtime_service() at a time, an > >> > + * ordered workqueue (which creates only one execution context) > >> > + * should suffice all our needs. > >> > + */ > >> > + efi_rts_wq = alloc_ordered_workqueue("efi_rts_workqueue", > >> > + 0); > >> > >> efi_rts_wq or efi_rts_workqueue? > >> > >> > + if (!efi_rts_wq) { > >> > + pr_err("Failed to create efi_rts_workqueue, EFI runtime services " > >> > >> Same here. > > > > Sure! I will make it consistent with "efi_rts_wq". Just tried to be > > more verbose with names :) > > > > It is not a big deal, but using the exact same name is better for the purposes of > grepping and things like that :-)
Yes, that makes sense.
> By the way, check the commit title/message, there are some others there too.
Sure! I will make changes to commit/title messages too.
Regards, Sai
| |