[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access
On Wed, Mar 07, 2018 at 12:23:56PM -0800, wrote:
> From: Kuppuswamy Sathyanarayanan <>
> In usb_serial_generic_submit_read_urb() function we are accessing the
> port->read_urbs array without any boundry checks. This might lead to
> kernel panic when index value goes above array length.
> One posible call path for this issue is,
> usb_serial_generic_read_bulk_callback()
> {
> ...
> if (!port->throttled) {
> usb_serial_generic_submit_read_urb(port, i, GFP_ATOMIC);
> ...
> }

How does i ever get to be greater than the array size here in this
function? It directly came from looking in that array in the first
place :)

So I don't see why your check is needed, what other code path would ever
call this function in a way that the bounds check would be needed?


greg k-h

 \ /
  Last update: 2018-03-07 21:59    [W:0.049 / U:3.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site