Messages in this thread | | | Subject | Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order | From | James Bottomley <> | Date | Wed, 07 Mar 2018 10:30:15 -0800 |
| |
On Wed, 2018-03-07 at 12:47 +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this:
> We can derive the order from sg->length and so do not need to pass it > in explicitly.
Is wrong. I can have a length 2 scatterlist that crosses a page boundary, but I can also have one within a single page, so the order cannot be deduced from the length.
James
| |