lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ssb:: use put_device() if device_register fail
On Wed, 7 Mar 2018 22:46:14 +0530
arvindY <arvind.yadav.cs@gmail.com> wrote:
> >> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> >> index 65420a9..c4449e0 100644
> >> --- a/drivers/ssb/main.c
> >> +++ b/drivers/ssb/main.c
> >> @@ -521,6 +521,7 @@ static int ssb_devices_register(struct ssb_bus *bus)
> >> ssb_err("Could not register %s\n", dev_name(dev));
> >> /* Set dev to NULL to not unregister
> >> * dev on error unwinding. */
> >> + put_device(dev);
> >> sdev->dev = NULL;
> >> kfree(devwrap);
> >> goto error;
> >
> > I don't think this is correct.
> > The dev structure is allocated as part of devwrap, which is freed here.
> >
> > Why do you think we need put_device here?
> >
> Yes this patch is not correct, We must not use kfree() after you called
> device_register() (even
> if it was not successful!) -- see the comment for device_register().
> I will delete kfree() and send updated patch.


Is device_put() going to call ssb_release_dev() to free the structure?

Can you please elaborate on why device_put() must be used? The comment
is not really of any use here.

--
Michael
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-03-07 18:39    [W:0.046 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site