Messages in this thread | | | Subject | Re: [PATCH 2/6] lib/scatterlist: Skip requesting zeroed allocations in sgl_alloc_order | From | Tvrtko Ursulin <> | Date | Wed, 7 Mar 2018 17:31:11 +0000 |
| |
On 07/03/18 15:35, Andy Shevchenko wrote: > On Wed, Mar 7, 2018 at 2:47 PM, Tvrtko Ursulin <tursulin@ursulin.net> wrote: > >> + sgl = kmalloc_array(nent, sizeof(struct scatterlist), (gfp & ~GFP_DMA)); > > The parens now become redundant.
True thanks! I am also not sure that re-using the same gfp_t for metadata is backing store is the right approach. At least I think __GFP_HIGHMEM needs also to be cleared for kmalloc.
Regards,
Tvrtko
| |