[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Regression] TPM char device not created if TPM 1.2 is disabled, but visible
> On 3/6/18, 3:14 AM, "Jarkko Sakkinen" <> wrote:
> On Mon, 2018-03-05 at 19:28 +0000, Sahil Rihan wrote:
> > Agree on keeping the warning.
> >
> > I'm guessing you want to return -ENODEV from tpm_bios_log_setup. Doing it from
> > tpm_read_log_acpi will just fall through to calling tpm_read_log_of, which I
> > think will end up returning -EIO again.
> >
> > In terms of semantics I'm not sure if -ENODEV is the right return code if the
> > BIOS event log is absent. I guess you can claim it's some sort of "device". I
> > don’t have a strong opinion here.
> >
> > Sahil
> You are absolutely right. Printing warning and returning zero would be
> the right measure to take.
> One more cosmetic detail. Should the log level be info or warn? I mean
> as far as I'm concerned everything is in a legit state.
> /Jarkko

Yeah, I tend to agree. I think INFO should be fine.

My reasoning is as follows: if the TPM is disabled, you shouldn't really be checking/using the BIOS event log measurements anyway.


 \ /
  Last update: 2018-03-07 23:35    [W:0.059 / U:6.080 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site