Messages in this thread | | | From | Logan Gunthorpe <> | Date | Tue, 6 Mar 2018 09:56:22 -0700 | Subject | Re: [PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 |
| |
On 06/03/18 05:37 AM, Horia Geantă wrote: > On 3/5/2018 9:08 PM, Logan Gunthorpe wrote: >> Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 >> functions in non-64bit cases in favour of the new common >> io-64-nonatomic-lo-hi header. >> >> To be consistent with CAAM engine HW spec: in case of 64-bit registers, >> irrespective of device endianness, the lower address should be read from >> / written to first, followed by the upper address. Indeed the I/O >> accessors in CAAM driver currently don't follow the spec, however this >> is a good opportunity to fix the code. >> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com> >> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> >> Cc: Horia Geantă <horia.geanta@nxp.com> >> Cc: Dan Douglass <dan.douglass@nxp.com> >> Cc: Herbert Xu <herbert@gondor.apana.org.au> >> Cc: "David S. Miller" <davem@davemloft.net> > Reviewed-by: Horia Geantă <horia.geanta@nxp.com> > > Please get used to carrying Reviewed-bys from previous iterations when patches > stay the same:
Sorry, I usually do this but I must have missed the email. Thanks.
Logan
| |