Messages in this thread | | | Date | Mon, 5 Mar 2018 11:01:26 -0700 | From | Ross Zwisler <> | Subject | Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg |
| |
On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler > <ross.zwisler@linux.intel.com> wrote: > > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > >> Dynamic debug can be instructed to add the function name to the debug > >> output using the +f switch, so there is no need for the nfit module to > >> do it again. If a user decides to add the +f switch for nfit's dynamic > >> debug this results in double prints of the function name like the > >> following: > >> > >> [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0 > >> > >> Thus remove the stray __func__ printing. > >> > >> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > > > > This makes sense to me, but I guess we'll see what Dan thinks. If we decide > > to go this route we may also want to do the same to all the instances of this > > pattern in the libnvdimm debug output. > > Is there a way to turn on this '+f' flag from the kernel boot command > line? My primary debug scenario is specifying "libnvdimm.dyndbg > nfit.dyndbg" on the command line.
Yep, it's just:
libnvdimm.dyndbg="+fp"
| |