lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drm/bridge/synopsys: dw-hdmi: Fix memleak in __dw_hdmi_remove
Date
The platform_device_register_full() will allocate dma_mask for
hdmi->audio, so we should free before platform_device_unregister().

Reported by kmemleak:
unreferenced object 0xffffffc0ef70ff00 (size 128):
comm "kworker/4:1", pid 123, jiffies 4294670080 (age 189.604s)
hex dump (first 32 bytes):
ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<0000000021946f44>] kmemleak_alloc+0x58/0x8c
[<000000009c43890d>] kmem_cache_alloc_memcg_trace+0x18c/0x25c
[<000000000e17cd06>] platform_device_register_full+0x64/0x108
[<00000000418a0882>] __dw_hdmi_probe+0xb9c/0xcc0
[<00000000e0b720fd>] dw_hdmi_bind+0x30/0x88
[<000000009af347f6>] dw_hdmi_rockchip_bind+0x260/0x2e8

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index f9802399cc0d..d9afdc59d4f4 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -2567,8 +2567,10 @@ __dw_hdmi_probe(struct platform_device *pdev,

static void __dw_hdmi_remove(struct dw_hdmi *hdmi)
{
- if (hdmi->audio && !IS_ERR(hdmi->audio))
+ if (hdmi->audio && !IS_ERR(hdmi->audio)) {
+ kfree(hdmi->audio->dev.dma_mask);
platform_device_unregister(hdmi->audio);
+ }
if (!IS_ERR(hdmi->cec))
platform_device_unregister(hdmi->cec);

--
2.11.0

\
 
 \ /
  Last update: 2018-03-05 08:46    [W:0.034 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site