lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task
    Date
    From: Xiaofei Tan <tanxiaofei@huawei.com>

    The current 110ms expiry time is not long enough for the internal
    abort task.

    The reason is that the internal abort task could be blocked in HW
    if the HW is retrying to set up link. The internal abort task will
    be executed only when the retry process finished.

    The maximum time is 5s for the retry of setting up link. So, the timer
    expire should be more than 5s. This patch increases it from 110ms to 6s.

    Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
    Signed-off-by: John Garry <john.garry@huawei.com>
    ---
    drivers/scsi/hisi_sas/hisi_sas_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
    index 9d16372..9ff8790 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
    @@ -871,6 +871,7 @@ static void hisi_sas_tmf_timedout(struct timer_list *t)

    #define TASK_TIMEOUT 20
    #define TASK_RETRY 3
    +#define INTERNAL_ABORT_TIMEOUT 6
    static int hisi_sas_exec_internal_tmf_task(struct domain_device *device,
    void *parameter, u32 para_len,
    struct hisi_sas_tmf_task *tmf)
    @@ -1574,7 +1575,7 @@ static int hisi_sas_query_task(struct sas_task *task)
    task->task_proto = device->tproto;
    task->task_done = hisi_sas_task_done;
    task->slow_task->timer.function = hisi_sas_tmf_timedout;
    - task->slow_task->timer.expires = jiffies + msecs_to_jiffies(110);
    + task->slow_task->timer.expires = jiffies + INTERNAL_ABORT_TIMEOUT*HZ;
    add_timer(&task->slow_task->timer);

    res = hisi_sas_internal_abort_task_exec(hisi_hba, sas_dev->device_id,
    --
    1.9.1
    \
     
     \ /
      Last update: 2018-03-05 15:52    [W:5.093 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site