lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC/RFT][PATCH 1/7] time: tick-sched: Reorganize idle tick management code
    On Mon, Mar 5, 2018 at 11:44 AM, Peter Zijlstra <peterz@infradead.org> wrote:
    > On Sun, Mar 04, 2018 at 11:24:00PM +0100, Rafael J. Wysocki wrote:
    >> +/**
    >> + * tick_nohz_idle_prepare - prepare for entering idle on the current CPU.
    >> + *
    >> + * Called when we start the idle loop.
    >> + */
    >> +void tick_nohz_idle_prepare(void)
    >> +{
    >> + __tick_nohz_idle_prepare();
    >> +
    >> + local_irq_enable();
    >> +}
    >
    > I really dislike the asymmetry in IRQ state you introduced here.
    > __tick_nohz_idle_prepare() disables IRQs. Must we do that?

    Not really, but at the cost of a tiny bit of duplicated code.

    \
     
     \ /
      Last update: 2018-03-05 12:27    [W:6.397 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site