Messages in this thread | | | Date | Sun, 4 Mar 2018 16:40:54 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 0/4] net: Use strlcpy() for ethtool::get_strings |
| |
On Fri, Mar 02, 2018 at 03:08:35PM -0800, Florian Fainelli wrote: > Hi all, > > After turning on KASAN on one of my systems, I started getting lots of out of > bounds errors while fetching a given port's statistics, and indeed using > memcpy() is unsafe for copying strings which have not been declared as an array > of ETH_GSTRING_LEN bytes, so let's use strlcpy() instead. This allows the best > of both worlds: we still keep the efficient memory usage of variably sized > strings, but we don't copy more than we need to.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |