lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 72/76] staging: ks7010: Remove dummy address set.
    Date
    Setting a dummy address during the driver probe is not necessary.
    The dev_addr field is already zeroed out from alloc_etherdev().

    Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
    ---
    drivers/staging/ks7010/ks_wlan_net.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
    index 5c5569000fce..afbc472baa05 100644
    --- a/drivers/staging/ks7010/ks_wlan_net.c
    +++ b/drivers/staging/ks7010/ks_wlan_net.c
    @@ -2852,9 +2852,6 @@ int ks_wlan_close(struct net_device *dev)
    /* Operational parameters that usually are not changed. */
    /* Time in jiffies before concluding the transmitter is hung. */
    #define TX_TIMEOUT (3 * HZ)
    -static const unsigned char dummy_addr[] = {
    - 0x00, 0x0b, 0xe3, 0x00, 0x00, 0x00
    -};

    static const struct net_device_ops ks_wlan_netdev_ops = {
    .ndo_start_xmit = ks_wlan_start_xmit,
    @@ -2882,9 +2879,6 @@ int ks_wlan_net_start(struct net_device *dev)
    atomic_set(&update_phyinfo, 0);
    timer_setup(&update_phyinfo_timer, ks_wlan_update_phyinfo_timeout, 0);

    - /* dummy address set */
    - ether_addr_copy(dev->dev_addr, dummy_addr);
    -
    /* The ks_wlan-specific entries in the device structure. */
    dev->netdev_ops = &ks_wlan_netdev_ops;
    dev->wireless_handlers = &ks_wlan_handler_def;
    --
    2.16.3
    \
     
     \ /
      Last update: 2018-03-30 09:12    [W:2.572 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site