Messages in this thread | | | Date | Fri, 30 Mar 2018 13:17:56 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v4 2/2] locking/debug: Restructure the lock debugging menu |
| |
* Waiman Long <longman@redhat.com> wrote:
> Two config options in the lock debugging menu that are probably the most > frequently used, as far as I am concerned, is the PROVE_LOCKING and > LOCK_STAT. From a UI perspective, they should be front and center. So > these two options are now moved to the top of the lock debugging menu. > > The DEBUG_WW_MUTEX_SLOWPATH option is also added to the PROVE_LOCKING > umbrella. > > Signed-off-by: Waiman Long <longman@redhat.com> > --- > lib/Kconfig.debug | 146 ++++++++++++++++++++++++++++-------------------------- > 1 file changed, 76 insertions(+), 70 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 6aad28c..dc9ffe2 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1034,6 +1034,79 @@ config DEBUG_PREEMPT > > menu "Lock Debugging (spinlocks, mutexes, etc...)" > > +config LOCK_DEBUGGING_SUPPORT > + bool > + depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT > + default y
Ok, this patch is a nice reorganization - but could we please split this into two patches, the first one adds the LOCK_DEBUGGING_SUPPORT helper, the other does the reordering of the entries (without changing anything in the entries)?
It's hard to review when the two steps are mixed up.
Thanks,
Ingo
| |