lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 107/219] drm: rcar-du: Handle event when disabling CRTCs
    Date
    From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

    [ Upstream commit 6dd47cfd03a058d08b8caffb06194aa0eb109cf1 ]

    The driver currently handles vblank events only when updating planes on
    a CRTC. The atomic update API however allows requesting an event when
    disabling a CRTC. This currently leads to event objects being leaked in
    the kernel and to events not being sent out. Fix it.

    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
    index 3322b157106d..1c4d95dea887 100644
    --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
    +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
    @@ -512,6 +512,13 @@ static void rcar_du_crtc_disable(struct drm_crtc *crtc)
    rcar_du_crtc_stop(rcrtc);
    rcar_du_crtc_put(rcrtc);

    + spin_lock_irq(&crtc->dev->event_lock);
    + if (crtc->state->event) {
    + drm_crtc_send_vblank_event(crtc, crtc->state->event);
    + crtc->state->event = NULL;
    + }
    + spin_unlock_irq(&crtc->dev->event_lock);
    +
    rcrtc->outputs = 0;
    }

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 00:47    [W:4.028 / U:26.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site