lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 092/102] mac80211: remove BUG() when interface type is invalid
    Date
    From: Luca Coelho <luciano.coelho@intel.com>

    [ Upstream commit c7976f5272486e4ff406014c4b43e2fa3b70b052 ]

    In the ieee80211_setup_sdata() we check if the interface type is valid
    and, if not, call BUG(). This should never happen, but if there is
    something wrong with the code, it will not be caught until the bug
    happens when an interface is being set up. Calling BUG() is too
    extreme for this and a WARN_ON() would be better used instead. Change
    that.

    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    net/mac80211/iface.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
    index 13b16f90e1cf..0fa844293710 100644
    --- a/net/mac80211/iface.c
    +++ b/net/mac80211/iface.c
    @@ -1474,7 +1474,7 @@ static void ieee80211_setup_sdata(struct ieee80211_sub_if_data *sdata,
    break;
    case NL80211_IFTYPE_UNSPECIFIED:
    case NUM_NL80211_IFTYPES:
    - BUG();
    + WARN_ON(1);
    break;
    }

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-03 23:28    [W:3.424 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site