lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 001/102] drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 85b4587f8e94143bafb8b6a4003a5187b9a8753d ]

    There is one caller which checks whether rpi_touchscreen_i2c_read()
    returns negative error codes. Currently it can't because negative
    error codes are truncated to u8, but that's easy to fix if we change the
    type to int.

    Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Eric Anholt <eric@anholt.net>
    Link: https://patchwork.freedesktop.org/patch/msgid/20171020002845.kar2wg7gqxg7tzqi@mwanda
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
    index 890fd6ff397c..d964d454e4ae 100644
    --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
    +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
    @@ -221,7 +221,7 @@ static struct rpi_touchscreen *panel_to_ts(struct drm_panel *panel)
    return container_of(panel, struct rpi_touchscreen, base);
    }

    -static u8 rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg)
    +static int rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg)
    {
    return i2c_smbus_read_byte_data(ts->i2c, reg);
    }
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-03 23:25    [W:4.276 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site