Messages in this thread | | | Date | Thu, 29 Mar 2018 10:33:58 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v3 0/5] Support perf -vv |
| |
On Thu, Mar 29, 2018 at 03:49:18PM +0800, Jin, Yao wrote:
SNIP
> > That would make it easier to grep around in the source looking for where code > > related a particular features is located. > > > > Good idea, thanks! I will support it in v4. > > > BTW. #2: to the compulsive perfectionist in me "HAVE_DWARF_GETLOCATIONS" is now > > sticking out like a sore thumb: it's the only library flag left that doesn't have > > the _SUPPORT suffix. Rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT perhaps? > > > > Thanks, > > > > Ingo > > > > OK, I will rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT in v4.
thanks for doing this, I'll ack the new version then
jirka
| |