Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection | Date | Wed, 28 Mar 2018 15:46:32 +0200 |
| |
On Sunday, January 07, 2018 05:02:21 PM SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 7 Jan 2018 15:56:11 +0100 > > Up to four checks could be repeated by the ufx_usb_probe() function > during error handling even if the relevant properties can be determined > for the involved variables before by source code analysis. > > * Return directly after a call of the function "kzalloc" failed > at the beginning. > > * Adjust jump targets so that extra checks can be omitted at the end. > > * Delete initialisations for the variables "info" and "retval" > which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch queued for 4.17, thanks.
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |