Messages in this thread | | | From | <> | Subject | RE: [PATCH -next] dm verity: make some functions static | Date | Wed, 28 Mar 2018 14:57:43 +0300 |
| |
Hi Wei, i'll add this fix, got this also from the kbuild test robot. Thank you, Yael
> -----Original Message----- > From: Wei Yongjun <weiyongjun1@huawei.com> > Sent: Wednesday, 28 March 2018 14:12 > To: Alasdair Kergon <agk@redhat.com>; Mike Snitzer <snitzer@redhat.com>; > yaeceh01 <yael.chemla@foss.arm.com> > Cc: Wei Yongjun <weiyongjun1@huawei.com>; dm-devel@redhat.com; linux- > kernel@vger.kernel.org; kernel-janitors@vger.kernel.org > Subject: [PATCH -next] dm verity: make some functions static > > Fixes the following sparse warnings: > > drivers/md/dm-verity-target.c:375:6: warning: > symbol 'verity_for_io_block' was not declared. Should it be static? > drivers/md/dm-verity-target.c:403:14: warning: > symbol 'verity_calc_buffs_for_bv' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/md/dm-verity-target.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c > index da35f0e..e70d4d2 100644 > --- a/drivers/md/dm-verity-target.c > +++ b/drivers/md/dm-verity-target.c > @@ -372,9 +372,9 @@ int verity_hash_for_block(struct dm_verity *v, struct > dm_verity_io *io, > /* > * Calculates the digest for the given bio > */ > -void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io, > - struct bvec_iter *iter, struct scatterlist *sg, > - unsigned int *nents, unsigned int *total_len) > +static void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io, > + struct bvec_iter *iter, struct scatterlist *sg, > + unsigned int *nents, unsigned int *total_len) > { > unsigned int todo = 1 << v->data_dev_block_bits; > struct bio *bio = dm_bio_from_per_bio_data(io, v->ti- > >per_io_data_size); @@ -400,8 +400,9 @@ void verity_for_io_block(struct > dm_verity *v, struct dm_verity_io *io, > * Calculate how many buffers are required to accommodate > * bio_vec starting from iter. > */ > -unsigned int verity_calc_buffs_for_bv(struct dm_verity *v, struct > dm_verity_io *io, > - struct bvec_iter *iter) > +static unsigned int verity_calc_buffs_for_bv(struct dm_verity *v, > + struct dm_verity_io *io, > + struct bvec_iter *iter) > { > unsigned int todo = 1 << v->data_dev_block_bits; > struct bio *bio = dm_bio_from_per_bio_data(io, v->ti- > >per_io_data_size);
| |