| From | Kees Cook <> | Date | Wed, 28 Mar 2018 04:25:37 -0700 | Subject | Re: [PATCH v2 16/21] kcov: imply GCC_PLUGINS and GCC_PLUGIN_SANCOV instead of select'ing them |
| |
On Mon, Mar 26, 2018 at 10:29 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > As Documentation/kbuild/kconfig-language.txt notes, 'select' should be > used with care - it forces a lower limit of another symbol, ignoring > the dependency. In this case, KCOV can select GCC_PLUGINS even if > 'depends on HAVE_GCC_PLUGINS' is unmet. > > 'imply' is modest enough to observe the dependency, and this makes > sense. If you enable KCOV, you will probably want to enable > GCC_PLUGIN_SANCOV, but it should not break the dependency. > > I also remove unneeded code, I just happened to notice. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook Pixel Security
|