Messages in this thread | | | Date | Wed, 28 Mar 2018 12:15:54 +0200 | From | "" <> | Subject | Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks |
| |
On 2018-03-26 11:13:59 [-0400], Steven Rostedt wrote: > > diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c > > index 9c7bc1ca341a..3d35dad1de2c 100644 > > --- a/drivers/target/target_core_tmr.c > > +++ b/drivers/target/target_core_tmr.c > > Can you add a comment above the functions though? > > /* Expects to have se_cmd->se_sess->sess_cmd_lock held */
I could. I haven't heard from Bart / Nicholas about their opinion. I know, we do this other places but Bart was against this kind of annotation in 2/2 of this thread. So I am waiting to hear from them :)
> > -- Steve
Sebastian
| |