| Date | Tue, 27 Mar 2018 10:04:50 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi |
| |
On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > + soc { > + pinctrl@1000000 { > + serial_0_pins: serial0_pinmux {
Please, no underscores in the node name.
> + mux {
Fyi, you can put the pinctrl properties directly into the state node, omitting the "mux" level.
> + pins = "gpio16", "gpio17"; > + function = "blsp_uart0"; > + bias-disable; > + }; > + }; > +
Apart from this the patch looks good.
Regards, Bjorn
|