lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:irq/core 12/13] drivers/irqchip/irq-vic.c:295:2: error: implicit declaration of function 'set_handle_irq'; did you mean 'vic_handle_irq'?
On Tue, 27 Mar 2018, Palmer Dabbelt wrote:
> On Mon, 26 Mar 2018 22:27:36 PDT (-0700), tglx@linutronix.de wrote:
> >
> > The commits in tip right now are:
> >
> > cc6c98485f8e ("RISC-V: Move to the new GENERIC_IRQ_MULTI_HANDLER handler")
> > caacdbf4aa56 ("genirq: Add CONFIG_GENERIC_IRQ_MULTI_HANDLER")
> >
> > I surely can revert them, but I don't see how they would break arm or
> > anything else.
>
> If GENERIC_IRQ_MULTI_HANDLER is set via randconfig then set_handle_irq() is
> pulled in from the generic code, which conflicts with the definitions in arm,
> arm64, and openrisc. The RISC-V commit depends on the genirq one.

Two ways to fix that:

- Rename set_handle_irq() in tip:irq/core and then convert the rest of the
tree over. A few more files touched, but nothing harmful

- Make GENERIC_IRQ_MULTI_HANDLER depend on !IRQ_MULTI_HANDLER. That should
cure it as well

Thanks,

tglx

\
 
 \ /
  Last update: 2018-03-27 17:39    [W:0.069 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site