| Subject | Re: [PATCH v2 15/21] gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT | From | Peter Oberparleiter <> | Date | Tue, 27 Mar 2018 11:12:06 +0200 |
| |
On 27.03.2018 07:29, Masahiro Yamada wrote: > CONFIG_GCOV_FORMAT_AUTODETECT compiles either gcc_3_4.c or gcc_4_7.c > according to your GCC version. > > We can achieve the equivalent behavior by setting reasonable dependency > with the knowledge of the compiler version. > > If GCC older than 4.7 is used, GCOV_FORMAT_3_4 is the default, but users > are still allowed to select GCOV_FORMAT_4_7 in case the newer format is > back-ported. > > On the other hand, If GCC 4.7 or newer is used, there is no reason to > use GCOV_FORMAT_3_4, so it should be hidden. > > If you down-grade your compiler GCC 4.7 or older, oldconfig/syncconfig > will display a prompt for the choice because GCOV_FORMAT_3_4 becomes > visible as a new symbol.
Looks sane to me.
Acked-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
-- Peter Oberparleiter Linux on Z Development - IBM Germany
|