Messages in this thread | | | Date | Fri, 23 Mar 2018 10:09:27 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn |
| |
On Thu, Mar 22, 2018 at 05:07:48PM +0100, Daniel Borkmann wrote:
SNIP
> >>> + va_end(args); > >>> +} > >>> EXPORT_SYMBOL_GPL(bpf_verifier_log_write); > >>> + > >>> +__printf(2, 3) static void print_ins(void *private_data, > >>> + const char *fmt, ...) > >> > >> Unless I am mistaken, you could just call this one "verbose()" and > >> simply remove the function alias? > > > > right you are ;-) I haven't realized that struct bpf_verifier_env *env > > will cleanly cast to void * > > > > new version attached.. I'll make some tests and send full patch > > When you do so, please make sure to send a full fresh series with the two > patches and also cover letter included, otherwise it's more fragile wrt > potentially applying the wrong patch from one of the replies. :-)
will do, thanks
jirka
| |