lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 109/177] qed: Unlock on error in qed_vf_pf_acquire()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>


    [ Upstream commit 66117a9d9a8ca948680d6554769ef9e88f936954 ]

    My static checker complains that we're holding a mutex on this error
    path. Let's goto exit instead of returning directly.

    Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_vf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c
    @@ -204,7 +204,7 @@ static int qed_vf_pf_acquire(struct qed_
    /* send acquire request */
    rc = qed_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp));
    if (rc)
    - return rc;
    + goto exit;

    /* copy acquire response from buffer to p_hwfn */
    memcpy(&p_iov->acquire_resp, resp, sizeof(p_iov->acquire_resp));

    \
     
     \ /
      Last update: 2018-03-23 12:17    [W:4.059 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site