lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 06/16] rtc: mediatek: remove unnecessary parentheses
    On 23/03/2018 at 17:15:03 +0800, sean.wang@mediatek.com wrote:
    > From: Sean Wang <sean.wang@mediatek.com>
    >
    > Remove unnecessary parentheses due to explicit C operator precedence.
    >
    > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
    > ---
    > drivers/rtc/rtc-mt6397.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
    > index 0df7ccd..4411c08 100644
    > --- a/drivers/rtc/rtc-mt6397.c
    > +++ b/drivers/rtc/rtc-mt6397.c
    > @@ -106,7 +106,7 @@ static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
    > int ret;
    >
    > ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_IRQ_STA, &irqsta);
    > - if ((ret >= 0) && (irqsta & RTC_IRQ_STA_AL)) {
    > + if (ret >= 0 && irqsta & RTC_IRQ_STA_AL) {

    I don't think this makes the code particularly clearer.

    > rtc_update_irq(rtc->rtc_dev, 1, RTC_IRQF | RTC_AF);
    > irqen = irqsta & ~RTC_IRQ_EN_AL;
    > mutex_lock(&rtc->lock);
    > --
    > 2.7.4
    >

    --
    Alexandre Belloni, Bootlin (formerly Free Electrons)
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2018-03-23 11:21    [W:4.558 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site