Messages in this thread | | | Subject | Re: [PATCH v2 1/2] x86, msr: add rdmsr_safe_on_cpu_resched() and use it in msr_read() | From | Eric Dumazet <> | Date | Fri, 23 Mar 2018 14:30:58 -0700 |
| |
On 03/23/2018 02:27 PM, Thomas Gleixner wrote: > > Looking at all call sites. None of them is performance critical and all of > them are in preemptible context. > > So we simply can switch the rdmsr_safe_on_cpu() implementation over to wait > mode completely.
SGTM, thanks for looking, I will send a v3 then.
> >> +/* Note: This version spins in smp_call_function_single(). >> + * Consider using rdmsr_safe_on_cpu_resched() variant instead. > > Bah. This is not networking code. x86 uses sensible comment style :)
Right ;)
| |