lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nfsd: use correct enum type in decode_cb_op_status
Applying, thanks!--b.

On Mon, Mar 19, 2018 at 11:37:05PM +0100, Stefan Agner wrote:
> Use enum nfs_cb_opnum4 in decode_cb_op_status. This fixes warnings
> seen with clang:
> fs/nfsd/nfs4callback.c:451:36: warning: implicit conversion from
> enumeration type 'enum nfs_cb_opnum4' to different enumeration
> type 'enum nfs_opnum4' [-Wenum-conversion]
> status = decode_cb_op_status(xdr, OP_CB_SEQUENCE, &cb->cb_seq_status);
> ~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> fs/nfsd/nfs4callback.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index 49b0a9e7ff18..1f04d2a70d25 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -223,8 +223,8 @@ static int nfs_cb_stat_to_errno(int status)
> return -status;
> }
>
> -static int decode_cb_op_status(struct xdr_stream *xdr, enum nfs_opnum4 expected,
> - int *status)
> +static int decode_cb_op_status(struct xdr_stream *xdr,
> + enum nfs_cb_opnum4 expected, int *status)
> {
> __be32 *p;
> u32 op;
> --
> 2.16.2

\
 
 \ /
  Last update: 2018-03-22 21:18    [W:0.026 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site