lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] drivers: remove force dma flag from buses
    > --- a/drivers/dma/qcom/hidma_mgmt.c
    > +++ b/drivers/dma/qcom/hidma_mgmt.c
    > @@ -398,7 +398,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
    > }
    > of_node_get(child);
    > new_pdev->dev.of_node = child;
    > - of_dma_configure(&new_pdev->dev, child);
    > + of_dma_configure(&new_pdev->dev, child, true);
    > /*
    > * It is assumed that calling of_msi_configure is safe on
    > * platforms with or without MSI support.

    Where did we mark this bus as force_dma before?

    > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
    > index 9a4f4246..895c83e 100644
    > --- a/drivers/of/of_reserved_mem.c
    > +++ b/drivers/of/of_reserved_mem.c
    > @@ -353,7 +353,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
    > /* ensure that dma_ops is set for virtual devices
    > * using reserved memory
    > */
    > - of_dma_configure(dev, np);
    > + of_dma_configure(dev, np, true);

    Did all the callers of this one really force dma? I have a hard time
    untangling the call stacks unfortunately.

    \
     
     \ /
      Last update: 2018-03-22 09:20    [W:3.502 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site