lkml.org 
[lkml]   [2018]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface
    From
    Date
    2018-03-21 18:00 UTC+0100 ~ Jiri Olsa <jolsa@redhat.com>
    > On Wed, Mar 21, 2018 at 05:44:52PM +0100, Daniel Borkmann wrote:
    >
    > SNIP
    >
    >>>> Hi Jiri, this code has changed in the tree. It was moved to
    >>>> tools/bpf/bpftool/xlated_dumper.c, and there is now a third function to
    >>>> update: print_insn_for_graph(). Could you please rebase the patch?
    >>>
    >>> sure.. I was over perf tree, I'll check on bpf tree
    >>
    >> Just to be sure, it should be bpf-next. bpf is for fixes only.
    >
    > v2 attached
    >
    > thanks,
    > jirka
    >
    >
    > ---
    > Change bpftool to skip the removed struct bpf_verifier_env
    > argument in print_bpf_insn. It was passed as NULL anyway.
    >
    > No functional change intended.
    >
    > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    > ---
    > tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >

    Thank you!
    Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>

    \
     
     \ /
      Last update: 2018-03-21 18:31    [W:3.401 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site