Messages in this thread | | | Date | Wed, 21 Mar 2018 12:45:38 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs |
| |
Em Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > > Hi Jiri, > > > > > > > > I'm still thinking it's worth displaying the warning when perf missing some > > > > libraries. > > > > > > > > Somebody just told me that perf didn't work well. While after some > > > > investigations, I found it's just missing some libraries when building the > > > > perf. > > > > > > > > But I have spent some time on getting the root cause. If with this patch, it > > > > should be very easily to know that. > > > > > > true.. Arnaldo, any feedback on this one? > > > > Lemme re-read the thread... > > Well, how about we make it harder to build without key libraries? I.e. > if we detect that what we consider a core set of libraries isn't found > in the system, then we stop the build, warn about it and ask the user to > confirm that the build should proceed by passing some explicit > -DI_KNOW_WHAT_I_AM_DOING___PROCEED=doit > > ?
And for some stuff, that we know people feel strongly about, like PeterZ with the TUI, the warning has to be subtle, like a one line "Please build with slang-devel to have interactive annotation".
- Arnaldo
| |