Messages in this thread | | | Date | Wed, 21 Mar 2018 10:30:49 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC |
| |
On Wed, Mar 21, 2018 at 10:27:13AM +0100, Greg KH wrote: > I hate the "bool" arguments to functions as you always need to go back > and look them up. A "wrapper" of "aio_fsync_datasync()" and > "aio_fsync_nodatasync()" around this maybe?
This is how the fsync API works. Wrappers really don't help anything, although flags would certainly be nicer. Next time I need to touch ->fsync for one reason or another that is high on the todo list.
| |