Messages in this thread Patch in this message | | | Subject | Re: [v2 PATCH 5/5] Staging:rtl8723bs clean spaces | From | Joe Perches <> | Date | Tue, 20 Mar 2018 13:32:35 -0700 |
| |
On Tue, 2018-03-20 at 20:26 +0000, Paul McQuade wrote: > Used checkpatch.pl to clean up spaces around if and for statements > to make it easier to read
Perhaps the commit message can be made clearer.
I think this is technically correct, but it would be nicer to describe these changes as moving braces to the more common kernel-style locations.
> diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c [] > @@ -20,8 +20,7 @@ > > void rtw_os_free_recvframe(union recv_frame *precvframe) > { > - if (precvframe->u.hdr.pkt) > - { > + if (precvframe->u.hdr.pkt) { > dev_kfree_skb_any(precvframe->u.hdr.pkt);/* free skb by driver */ > > precvframe->u.hdr.pkt = NULL;
| |