lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function
I'm trying to review this, but I feel like this makes it slightly more
complicated for no reason. Why break it up into two loops?

> - i++;
> + ++i;

These are equivalent, so you should default to accepting the original
author's style. Otherwise the next person to touch this code will just
change it back and we get into a cycle of pointless changes.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-03-20 12:22    [W:0.053 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site