lkml.org 
[lkml]   [2018]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 12/24] led: core: Fix brightness setting when setting delay_off=0
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matthieu CASTET <matthieu.castet@parrot.com>


    [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]

    With the current code, the following sequence won't work :
    echo timer > trigger

    echo 0 > delay_off
    * at this point we call
    ** led_delay_off_store
    ** led_blink_set
    ---
    drivers/leds/led-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/leds/led-core.c
    +++ b/drivers/leds/led-core.c
    @@ -76,7 +76,7 @@ void led_blink_set(struct led_classdev *
    unsigned long *delay_on,
    unsigned long *delay_off)
    {
    - del_timer_sync(&led_cdev->blink_timer);
    + led_stop_software_blink(led_cdev);

    led_cdev->flags &= ~LED_BLINK_ONESHOT;
    led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP;

    \
     
     \ /
      Last update: 2018-03-02 12:23    [W:2.573 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site