Messages in this thread | | | Subject | Re: [RESEND PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev | From | Sergei Shtylyov <> | Date | Fri, 2 Mar 2018 12:21:49 +0300 |
| |
On 3/1/2018 10:15 PM, Moritz Fischer wrote:
> This adds bindings for the NI XGE 1G/10G network device. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Moritz Fischer <mdf@kernel.org> > --- > > Changes from v3: > - Added Rob's Reviewed-by > > Changes from v2: > - Addressed Rob's comments w.r.t to IRQ names and typo > > Changes from v1: > - Corrected from nixge -> nixge.txt > --- > Documentation/devicetree/bindings/net/nixge.txt | 32 +++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nixge.txt > > diff --git a/Documentation/devicetree/bindings/net/nixge.txt b/Documentation/devicetree/bindings/net/nixge.txt > new file mode 100644 > index 000000000000..e55af7f0881a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nixge.txt > @@ -0,0 +1,32 @@ > +* NI XGE Ethernet controller > + > +Required properties: > +- compatible: Should be "ni,xge-enet-2.00" > +- reg: Address and length of the register set for the device > +- interrupts: Should contain tx and rx interrupt
Maybe rx and tx, looking below:
> +- interrupt-names: Should be "rx" and "tx" > +- phy-mode: See ethernet.txt file in the same directory. > +- phy-handle: See ethernet.txt file in the same directory. > +- nvmem-cells: Phandle of nvmem cell containing the MAC address > +- nvmem-cell-names: Should be "address" [...]
MBR, Sergei
| |