lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 3.18 095/102] scsi: libsas: fix memory leak in sas_smp_get_phy_events()
    Date
    From: Jason Yan <yanaijie@huawei.com>

    [ Upstream commit 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4 ]

    We've got a memory leak with the following producer:

    while true;
    do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null;
    done

    The buffer req is allocated and not freed after we return. Fix it.

    Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
    Signed-off-by: Jason Yan <yanaijie@huawei.com>
    CC: John Garry <john.garry@huawei.com>
    CC: chenqilin <chenqilin2@huawei.com>
    CC: chenxiang <chenxiang66@hisilicon.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/scsi/libsas/sas_expander.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
    index 0cac7d8fd0f7..98783fecd0b7 100644
    --- a/drivers/scsi/libsas/sas_expander.c
    +++ b/drivers/scsi/libsas/sas_expander.c
    @@ -684,6 +684,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy)
    phy->phy_reset_problem_count = scsi_to_u32(&resp[24]);

    out:
    + kfree(req);
    kfree(resp);
    return res;

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 17:20    [W:4.067 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site